Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle weird edge case where the extra_settings key does not exist yet. #11545

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

rtibbles
Copy link
Member

Summary

  • When upgrading, it appears it is possible for this key to be unavailable on the model object
  • Adds a defensive check when trying to access this value

References

Fixes #11518

Reviewer guidance

I am not entirely sure how this even happens - but this defensive check seemed the simplest way to handle it.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Nov 20, 2023
@rtibbles rtibbles requested a review from jredrejo November 20, 2023 13:07
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: very small labels Nov 20, 2023
Copy link
Member

@jredrejo jredrejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjester bjester merged commit 7168ca1 into learningequality:release-v0.16.x Nov 20, 2023
34 checks passed
@pcenov
Copy link
Member

pcenov commented Nov 21, 2023

Tested the upgrade scenario on MacOS, Linux and Windows and it's working fine now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: very small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temporary getting a 'Server Error (500)' after upgrading Kolibri 0.15.12 to Kolibri 0.16 beta 7
4 participants